[tests] tighten keep_in_32 modules tests - #14399
Merged
Merged
Conversation
dg845
reviewed
Aug 13, 2026
Comment on lines
+551
to
+553
| # Lives here rather than next to the other layerwise casting tests because it asserts | ||
| # `_keep_in_fp32_modules` semantics (`enable_layerwise_casting` folds it into the skip patterns) and needs | ||
| # no accelerator, while the layerwise casting mixin is accelerator-gated. |
Collaborator
There was a problem hiding this comment.
nit: I think this comment might be a little inaccurate as LayerwiseCastingTesterMixin doesn't have a @require_accelerator decorator, but MemoryTesterMixin does. (But I think we always use MemoryTesterMixin in practice, so maybe it's a moot point.)
Member
Author
There was a problem hiding this comment.
But I think we always use MemoryTesterMixin
I didn't get this point, sorry.
dg845
approved these changes
Aug 13, 2026
dg845
left a comment
dg845
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Left one small comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title suggests.
_keep_in_fp32_modulesis an important model class-level attribute that deserves better functional testing. In particular, this PR adds / modifies the following:require_acceleratormarker fromtest_keep_in_fp32_modulesbecause there's no computation being run there. CPU is enough for that test._keep_in_fp32_modules